perf: split Core.Context into hot and cold subobjects - #14962
Merged
Conversation
Member
Author
|
!bench |
Member
Author
|
!bench mathlib |
|
Benchmark results for b76d5ba against e991a05 are in. There are significant results. @Kha
Large changes (20✅, 4🟥)
Medium changes (17✅, 1🟥)
Small changes (566✅, 3🟥)
|
|
Benchmark results for leanprover-community/mathlib4-nightly-testing@be38686 against leanprover-community/mathlib4-nightly-testing@78f2465 are in. There are significant results. @Kha
Large changes (1✅)
Small changes (80✅)
|
Collaborator
|
Reference manual CI status:
|
Kha
enabled auto-merge
August 29, 2026 10:42
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-0.5% instrs, -1.3/1.8% wall-clock core/Mathlib
withReadercan never reuse theContextrecord as the caller is owning a reference, so everywithRef,withOptionsorwithIncRecDepthpays one reference count increment per pointer field. Grouping these fields into a subobject makes them cost a single increment together.