Skip to content

perf: avoid setTransparency when the transparency is already in effect #14967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kha wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −4
Draft

perf: avoid setTransparency when the transparency is already in effect #14967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Lean/Meta/Basic.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1304,8 +1304,10 @@ private def Context.setTransparency (ctx : Context) (transparency : Transparency
{ ctx with keyedConfig := ctx.keyedConfig.setTransparency transparency }

@[inline] def withTransparency (mode : TransparencyMode) : n α → n α :=
-- We avoid `withConfig` for performance reasons.
mapMetaM <| withReader (·.setTransparency mode)
-- We avoid `withConfig` for performance reasons. `setTransparency` rebuilds `Config`,
-- `ConfigWithKey` and `Context`, so skip it when the mode is already in effect.
mapMetaM <| withReader fun ctx =>
if ctx.config.transparency == mode then ctx else ctx.setTransparency mode

/-- `withDefault x` executes `x` using the default transparency setting. -/
@[inline] def withDefault (x : n α) : n α :=
Expand Down Expand Up @@ -1338,8 +1340,7 @@ Recall that `.none < .reducible < .instances < .implicit < .default < .all`.
-/
@[inline] def withAtLeastTransparency (mode : TransparencyMode) : n α → n α :=
mapMetaM <| withReader fun ctx =>
let modeOld := ctx.config.transparency
ctx.setTransparency <| if modeOld.lt mode then mode else modeOld
if ctx.config.transparency.lt mode then ctx.setTransparency mode else ctx

/-- Execute `x` allowing `isDefEq` to assign synthetic opaque metavariables. -/
@[inline] def withAssignableSyntheticOpaque (x : n α) : n α :=
Expand Down
Loading