Add deserialization_exception field for programmatic error handling#316
Open
bjester wants to merge 2 commits intolearningequality:release-v0.8.xfrom
Open
Add deserialization_exception field for programmatic error handling#316bjester wants to merge 2 commits intolearningequality:release-v0.8.xfrom
bjester wants to merge 2 commits intolearningequality:release-v0.8.xfrom
Conversation
ozer550
reviewed
Apr 20, 2026
ozer550
requested changes
Apr 20, 2026
Member
ozer550
left a comment
There was a problem hiding this comment.
I might be wrong but it seems like we are doing opposite of "skip rows that previously failed deserialization" ? Was this change in behavior intended? Also adding some tests to verify the null string change for skipping would be useful!
ozer550
reviewed
Apr 23, 2026
Member
ozer550
left a comment
There was a problem hiding this comment.
I did a grep on places where we had "deserialization_exception" and found a place where we might need to add the execution path as well?
Member
Author
|
@ozer550 I've updated it to set the exception in the code you found. I also grepped and found some backend code setting to empty string. We probably didn't to set it there, but I updated the code anyway, to be have parity with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This allows programmatic handling of deserialization errors instead of parsing error messages
deserialization_exceptionnullable field toStoremodel that stores the fully-qualified exception class path when deserialization failsdeserialization_errorfield to be nullableReferences
Followup to #306
Closes #315
AI Usage
Directed an AI agent to tackle the issue, iterated on its work for a loop, then did a small refactor myself. Had the AI agent add test coverage, then reviewed.