Fix v0.4.0 Web media helper compatibility - #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adapt all three Web media helper call sites to llama.cpp v0.4.0's new options parameter without dropping older upstream compatibility. CMake detects the declaration at configure time; one private buffer/file shim passes upstream defaults and preserves non-placeholder behavior. No JS/public ABI, source pin, consumer pin, capability, or automatic publication policy changes.
Closes #90.
Closes #92 (pre-existing contradictory speech qualification guidance; docs only).
Regression prevention
5266f24da75dc449bd56cbed7addb9c8e4a6a73ealongside the unchangedllama_cpp.versionpin. Both build wasm32/memory64 and run state/multimodal direct+worker smokes. Preserve the original pinned check/artifact names and isolate matrix uploads.Validation
npm run check:js, generated-output no-diff, full Python contract suite 353/353, compiled helper tests 2/2, wasm64 patch contracts 3/3, state/TTS/CI reliability contracts, actionlint, Python compile, and diff check PASS.20e4663d97302e7906c7557c31ab4c98dbaabcefagainst base646037ac816c066d3f7d9e357139ca20800dc7ee. Zero known PR-caused regressions, zero unresolved threads, and no remaining cleanup/code blocker. Sol independently reran focused contracts, actionlint, and diff checks. An incorrect private-runtime reference in the new smoke harness was caught and corrected before the initial commit, and the final negative browser assertions passed on all three upstream versions.All validation is complete on exact head
20e4663d97302e7906c7557c31ab4c98dbaabcef. Hosted CI run 33966949306: 2/2 matrix jobs PASS, including both memory-mode builds, state persistence, and real multimodal direct/worker tests for current pin and v0.4.0. Final GitHub state: MERGEABLE/CLEAN, draft, 0 total/0 unresolved review threads. No GitHub review is populated; independent Sol approval is recorded above. No known regression remains. Mark-ready/merge is a separate maintainer decision; no merge, dispatch, publication, release, or pin update was performed.Pinned model provenance: Qwen3.5
bd258782e35f7f458f8aced1adc053e6e92e89bc735ba3be89d38a06121dc517/ projector56e4c6cfe73b0c82e3e82bc518d7591997e61d81f723fc41a586f4fa69ea2453; ASRbca259818b50ca7c4c05e9bdb35a5dc04fa039653a6d6f3f0f331f96f6aa1971/ projector41a342b5e4c514e968cb756de6cd1b7be39eff43c44c57a2ef5fc6522e36603d; TTS8d18c94acb2addd042f97da63c98be144eafa76d0d9495177eab65130cf85129/ projector6fd65188839bcd6ecc91b277ad471e22a0edfada4699a0fe82f1165c18cfcce2; speaker WAVde964f9d761766be44fdf648c961f9232cd53cb14373c20b6046106f06661203. TTS promptHi, initial synthesis seed 1 (cancellation/reuse seeds 2/3), Apple M4 Max CPU/WASM fallback.Limits / release boundary
Local browser validation uses CPU/WASM fallback; no hardware WebGPU claim. TTS uses memory64, not an unvalidated wasm32 configuration. No full video capability is introduced. This is upgrade preparation, not a claim that published Web v0.1.41 is defective. No release, workflow dispatch, asset publication, or downstream pin change is part of this PR.