fix: validate metadata-only release readiness evidence - #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #485.
Scope and safety
The metadata route requires
release-metadata-verification, its exact strict-release-verifier/test command, PASS evidence and exactly the unchangedtest/unit/tooling/verify_release_docs_companion_pins_test.dart. The verifier and test must be identical regular Git blobs at base/head. The evaluator does not execute candidate scripts or authenticate a claimed test run; independent review must inspect actual command evidence.Any hook/runtime/pin/binding/Swift/workflow/policy change, broader companion release, renamed/added/deleted/nonregular path, dependency/SDK/source/hash/path/inventory lock change, stale snippet, historical changelog rewrite or executable MDX activation cannot use this route. Documentation prose remains independently reviewed. Normal high-risk changes retain the changed-production-test requirement.
This fixes a pre-existing policy mismatch exposed by release PR #482, not a runtime regression caused by that release or Apple guard #484. Release #482 stays draft and is not modified by this corrective PR.
Validation
16eaa80fcdb7578599d8757056cfb18536a642cb/ baseccc2d35633e3ca6347a697f19fde4944e0a8dbd0reachesunverifiedPrerequisitesinstead ofmissingTestPathwithout changing its diff or inventing a changed test.High-risk regression review
/private/tmp/llamadart-readiness-485.a8bb6ff318d2ef028b81f549cd1aefe7929abf07; baseccc2d35633e3ca6347a697f19fde4944e0a8dbd0.Explicit boundary
Successful local high-risk evaluation still returns only
unverifiedPrerequisites(exit2),isReady=false. No payload, flag, credential or environment variable can produce operational-ready output. Protected external enforcement remains separately governed and unconfigured by design; this PR neither enables nor weakens it.No mark-ready, merge, publication, tag, dispatch, settings or runtime-pin action is included.