Fix Windows discovery-exit test fixture - #382
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy discovery fixture could close stdin without exiting promptly on Windows. The client then reached its discovery timeout and attempted initialization against the old process, intermittently failing the platform smoke test.
Explicitly exit the fixture with status 0 when it receives
server/discover, so the existing tests exercise recovery after a child exit. SDK runtime behavior and dependency versions are unchanged.Validation: all 1,986 SDK tests pass locally, including the 46 stdio client tests, fresh-child fallback, and the
require2026rejection case. Static analysis, formatting, and diff checks pass. The unchanged dependency PR #378 also passed its targeted Windows rerun, confirming that the original failure is intermittent. Windows CI for this fixture change is still required after pushing.