Skip to content

Fix missing/broken Japanese translations for meeting-dismissal and access-denied strings - #971

Open
nashirox wants to merge 1 commit into
leits:masterfrom
nashirox:fix/ja-localization-missing-strings
Open

Fix missing/broken Japanese translations for meeting-dismissal and access-denied strings#971
nashirox wants to merge 1 commit into
leits:masterfrom
nashirox:fix/ja-localization-missing-strings

Conversation

@nashirox

@nashirox nashirox commented Aug 26, 2026

Copy link
Copy Markdown

What changed and why

Several UI strings fall back to raw English (or, before recent refactors, to raw i18n keys) in the Japanese locale, as reported in #867, #858, #881, and #854. Since ja.lproj already has the same key count as en.lproj (349/349, no missing/extra keys) and the tab-title/$key$-placeholder bugs from those reports appear to already be fixed by the recent preferences UI rewrite, the remaining gap is 8 keys where ja.lproj still holds the literal English string instead of a translation — the meeting-dismissal feature strings and the calendar access-denied banner's "Go to" label. Other locales (German, French, Korean, etc.) already have these translated; Japanese was simply behind.

This PR adds Japanese translations for:

  • status_bar_menu_remove_all_dismissals
  • status_bar_event_dismissed_mark
  • notification_next_meeting_dismissed_title
  • notification_next_meeting_dismissed_message
  • notification_all_dismissals_removed_title
  • notification_all_dismissals_removed_message
  • status_bar_submenu_undismiss_meeting
  • access_screen_access_screen_access_denied_go_to_title

Wording follows the "dismiss = 閉じる" terminology already established elsewhere in ja.lproj (e.g. status_bar_submenu_dismiss_meeting, status_bar_menu_dismiss_curent_meeting) for consistency.

User-visible behavior changes

Japanese-locale users will see these 8 strings in Japanese instead of English.

Tests / validation run

  • plutil -lint on the modified .strings file — OK
  • make validate-stringsOK: 282 used keys all defined in English (349 total defined).

Note on scope

Per CONTRIBUTING.md, non-English translations are normally managed through Weblate. These 8 keys have sat untranslated in Japanese for a while (some since 2022) despite being translated in most other locales, so I'm proposing a direct fix here rather than waiting on a future Weblate sync — happy to route this through Weblate instead if that's preferred.

Summary by CodeRabbit

  • Localization
    • Updated Japanese translations for meeting dismissal controls.
    • Added Japanese text for calendar access navigation and related status bar and notification messages.
    • Replaced English fallback text with localized Japanese translations.

…ings

Several keys used by the meeting-dismissal feature and the calendar
access-denied banner were never translated into Japanese and fell back
to raw English (status_bar_menu_remove_all_dismissals,
status_bar_event_dismissed_mark, notification_next_meeting_dismissed_title/
message, notification_all_dismissals_removed_title/message,
status_bar_submenu_undismiss_meeting,
access_screen_access_screen_access_denied_go_to_title), matching the
gaps reported in leits#867, leits#858, leits#881, and leits#854. Wording follows the
existing dismiss/close terminology already used elsewhere in ja.lproj.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 00cbcf72-e672-4cb2-8939-0ac6c5ab55b0

📥 Commits

Reviewing files that changed from the base of the PR and between b51762b and d188fa1.

📒 Files selected for processing (1)
  • MeetingBar/Resources /Localization /ja.lproj/Localizable.strings

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


Walkthrough

The Japanese localization replaces English fallback strings for meeting dismissal controls, calendar access navigation, and dismissed-meeting restoration messages.

Changes

Japanese localization

Layer / File(s) Summary
Translate meeting controls and navigation
MeetingBar/Resources /Localization /ja.lproj/Localizable.strings
Japanese translations now cover undismiss controls, calendar access navigation, and dismissed-meeting restoration messages.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d188f

This localized change only replaces eight Japanese-locale English fallbacks with Japanese translations, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers: key, leits

Poem

A rabbit hops through strings so bright

Japanese words replace English light
Meetings return with careful cheer
Calendar paths are crystal clear
Localization blooms this year

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing Japanese translations for meeting dismissal and access-denied strings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant