Fix missing/broken Japanese translations for meeting-dismissal and access-denied strings - #971
Fix missing/broken Japanese translations for meeting-dismissal and access-denied strings#971nashirox wants to merge 1 commit into
Conversation
…ings Several keys used by the meeting-dismissal feature and the calendar access-denied banner were never translated into Japanese and fell back to raw English (status_bar_menu_remove_all_dismissals, status_bar_event_dismissed_mark, notification_next_meeting_dismissed_title/ message, notification_all_dismissals_removed_title/message, status_bar_submenu_undismiss_meeting, access_screen_access_screen_access_denied_go_to_title), matching the gaps reported in leits#867, leits#858, leits#881, and leits#854. Wording follows the existing dismiss/close terminology already used elsewhere in ja.lproj. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughThe Japanese localization replaces English fallback strings for meeting dismissal controls, calendar access navigation, and dismissed-meeting restoration messages. ChangesJapanese localization
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change only replaces eight Japanese-locale English fallbacks with Japanese translations, with no actionable merge-blocking risk remaining after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed and why
Several UI strings fall back to raw English (or, before recent refactors, to raw i18n keys) in the Japanese locale, as reported in #867, #858, #881, and #854. Since
ja.lprojalready has the same key count asen.lproj(349/349, no missing/extra keys) and the tab-title/$key$-placeholder bugs from those reports appear to already be fixed by the recent preferences UI rewrite, the remaining gap is 8 keys whereja.lprojstill holds the literal English string instead of a translation — the meeting-dismissal feature strings and the calendar access-denied banner's "Go to" label. Other locales (German, French, Korean, etc.) already have these translated; Japanese was simply behind.This PR adds Japanese translations for:
status_bar_menu_remove_all_dismissalsstatus_bar_event_dismissed_marknotification_next_meeting_dismissed_titlenotification_next_meeting_dismissed_messagenotification_all_dismissals_removed_titlenotification_all_dismissals_removed_messagestatus_bar_submenu_undismiss_meetingaccess_screen_access_screen_access_denied_go_to_titleWording follows the "dismiss = 閉じる" terminology already established elsewhere in
ja.lproj(e.g.status_bar_submenu_dismiss_meeting,status_bar_menu_dismiss_curent_meeting) for consistency.User-visible behavior changes
Japanese-locale users will see these 8 strings in Japanese instead of English.
Tests / validation run
plutil -linton the modified.stringsfile — OKmake validate-strings—OK: 282 used keys all defined in English (349 total defined).Note on scope
Per
CONTRIBUTING.md, non-English translations are normally managed through Weblate. These 8 keys have sat untranslated in Japanese for a while (some since 2022) despite being translated in most other locales, so I'm proposing a direct fix here rather than waiting on a future Weblate sync — happy to route this through Weblate instead if that's preferred.Summary by CodeRabbit