Minor fixes and enhancements - #23
Merged
Merged
Conversation
• Added dg-not-sortable class to <th> elements in applyColumnDefinition when column.noSort is true. • Restricted class assignment to <th> elements only, excluding <td> body cells. • Fixed a return/continue regression in sortChanged left over from a past forEach-to-for...of refactor, which caused the loop to exit early instead of skipping only the current non-sortable column.
Owner
|
looking good as always |
Owner
|
@jackkjhsu realized some stuff really needs some update on this repo, i'm going to make some cleanup on top of that |
Contributor
Author
|
Thank you so much Thomas! |
Owner
|
@jackkjhsu i've published 2.1.0 not many changes, but much needed cleanup that makes the project easier to work with |
Contributor
Author
|
Thanks Thomas. Your fixes look good, no issues so far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Thomas,
I hope you're doing well theses days. I made some minor changes since the end of last year for fixes and improvements. I hope these are ok.
Thank you