fix(server create): tolerate non-git cwd when checking work tree#88
Merged
Conversation
`git rev-parse --is-inside-work-tree` exits 128 outside a repo and aborted `lt server create` after a successful template clone; treat that as false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lt server create(including--next) aborting after a successful template clone when run outside a git repositorygit rev-parse --is-inside-work-treenow treats exit code 128 as "not in a work tree" instead of failing the commandTest plan
npm test(pre-push hook)lt server create bp-api --next --noConfirmfrom a directory that is not a git repo and confirm it completes with next steps printedgit initunless--gitis set)