fix(scaffold): reconfigure .claude/upstream.json for downstream on nest-base scaffold

[pascal-klesse]

Problem

The experimental nest-base template ships .claude/upstream.json with the template-self default:

{ "isTemplate": true, "upstream": null, "syncedPaths": ["src/core/"] }

bun run rename only rewrites four files (package.json, README.md, portless.yml, docker-compose.yml) and never touches upstream.json. So every project scaffolded from nest-base keeps isTemplate: true — which makes the /upstream-pr slash command and the contributing-upstream skill refuse to open core-fix PRs back to nest-base ("this repo IS the template"). Downstream projects could never contribute fixes upstream without a manual edit nobody remembers.

Fix

New helper reconfigureUpstreamForDownstream() in src/lib/workspace-integration.ts:

• Reads ${apiDir}/.claude/upstream.json; missing file or unparseable JSON → { updated: false } (non-fatal, no throw — older templates may not ship it).
• Sets isTemplate: false and upstream: { repo: "lenneTech/nest-base", branch }, preserving $schema and syncedPaths. Replaces the stale template-self notes.
• Idempotent.

Wired into all three nest-base scaffold paths:

• lt fullstack add-api --next (src/commands/fullstack/add-api.ts)
• lt fullstack init --next (src/commands/fullstack/init.ts)
• lt server create --next (src/commands/server/create.ts, standalone clone at project root)

Each surfaces a one-line info on success; absence is silent and non-fatal.

Tests

New describe('reconfigureUpstreamForDownstream') block in __tests__/workspace-integration.test.ts (5 tests, gluegun real filesystem + temp dir): flips isTemplate + fills upstream; preserves syncedPaths/$schema; honours custom repo/branch; missing file → no-op; idempotent.

Test plan

• npm run lint — clean
• npm run test — 355 passed, 1 pre-existing skip
• npm run build — note: tsc has 2 pre-existing, unrelated errors in node_modules (electron.d.ts / @types/node noDeprecation modifier conflict), verified identical on a clean tree. The changed source compiles clean.

Origin

Discovered while contributing a src/core/ fix back from a downstream consumer project (see lenneTech/nest-base#155) — /upstream-pr refused because the scaffolded upstream.json still said isTemplate: true.

🤖 Generated with Claude Code