go: use UTF8DecodeInvalid in fxamacker/cbor wrapper - #80
Merged
Conversation
This commit uses a decoding option to disable UTF-8 validation because generated fixtures are valid UTF-8 and trusted. Skipping UTF-8 validation improves decoding speed by 2-12%, depending on string content. Other changes: - correct a comment about CoreDet - fix a broken link in a comment - add a comment to mention fxamacker/cbor provides toarray and keyasint struct tag options that can further improve performance and reduce encoded size if they are added to Go structs in the benchmark file (model/v2/generate.go)
leo-gan
reviewed
Aug 12, 2026
leo-gan
left a comment
leo-gan
left a comment
Owner
There was a problem hiding this comment.
Review notes:
Change: DecOptions{UTF8: cbor.UTF8DecodeInvalid} skips UTF-8 validation on decode. API exists in the pinned fxamacker/cbor/v2 v2.9.2. Fixtures are generated/trusted, so this is appropriate for a throughput path and matches the library author's recommendation.
Comments: CoreDet note clarification, fixed docs link, and notes about toarray/keyasint (informational only — structs are unchanged).
Scope: Single-file harness tweak; no go.mod change. Local go test ./serializers/ passes on this branch.
Approving and squash-merging.
leo-gan
approved these changes
Aug 12, 2026
leo-gan
left a comment
leo-gan
left a comment
Owner
There was a problem hiding this comment.
Sensible throughput-path decode option for trusted benchmark fixtures; comments are accurate. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses a decoding option to disable UTF-8 validation because generated fixtures are valid UTF-8 and trusted. Skipping UTF-8 validation improves decoding speed by 2-12%, depending on string content.
Other changes: