fix(php): stop a declared bundled extension from replacing the image's build - #1624
Merged
Conversation
…s build The image compiles its bundled extensions as part of its own configure run, with flags a standalone build layered on top cannot pass. A declared custom extension that names one of them rebuilds it generically anyway, so the better build is quietly replaced: ftp came back without OpenSSL and lost ftp_ssl_connect again, right after the base image had been fixed to ship it. Builds now skip any bundled name in the declared set, which heals a declaration that is already there, and php:ext add refuses one up front rather than starting a rebuild that can only make the image worse. Refs #1576
…clared Skipping a bundled name at build time only helps an image built after the change. The fingerprint an image carries is taken from the declared set, and the declared set does not move when the binary starts ignoring part of it, so an image built while a declared ftp was still replacing the base image's own read as current forever and kept the lesser build until someone forced a rebuild by hand. The fingerprint now covers the set the build will actually realise, bundled names and their apk deps left out. An image built before this reads as out of date exactly once, and the next thing that touches the version puts the image's own build back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image compiles its bundled extensions as part of its own configure run, with flags a standalone build layered on top cannot pass. A declared custom extension that names one of them rebuilds it generically anyway, so the better build is quietly replaced: ftp came back without OpenSSL and lost
ftp_ssl_connectagain, right after the base image had been fixed to ship it.Builds now skip any bundled name in the declared set, which heals a declaration that is already there, and
php:ext addrefuses one up front rather than starting a rebuild that can only make the image worse.Refs #1576