Allow users to create a guild war specific game through lfg command - #2537
Merged
lexicalunit merged 3 commits intoAug 5, 2026
Merged
Conversation
lexicalunit
self-requested a review
August 5, 2026 02:29
- Change command to /war for easier usage - Fix a failing unit test - Surface guild war info in website - Parameterize i18n files - Increase test coverage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2537 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 286 287 +1
Lines 22863 23311 +448
Branches 933 949 +16
==========================================
+ Hits 22863 23311 +448 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of the changes and motivation for the PR.
Add optional
/lfg guild_warwith autocomplete from Convoke live warsForce Convoke and send
warIdon create-game (open seating; no pod mode)Persist war id/title on games and show it on the embed
Resolves # (issue number)
N/A
Checklist
Add tests for these changes
Test coverage is not decreased
Entire test suite passes