Handle recarrays for automatically generated tests in a single place - #318
Merged
Conversation
In some of the tests created by `erfa_generator` arrays should be viewed as recarrays so that data in them could be accessed by named attributes. So far creating the recarrays has been handled in two different `TestFunction` methods, but now it is done in just one.
avalentino
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some of the tests created by
erfa_generatorarrays should be viewed as recarrays so that data in them could be accessed by named attributes. On currentmaincreating the recarrays is handled in two differentTestFunctionmethods, but in this PR it is done in just one. There are two small changes to the generatedtest_ufunc.pyfile:The changes are in the
test_aper()andtest_aper13()functions. From what I can tell in both cases the new versions of the generated tests are more similar to the ERFA C tests than the old versions.