Simplify extracting arguments from test calls - #319
Merged
Conversation
Among other things `erfa_generator` translates ERFA C tests to Python tests, which requires extracting arguments from C function calls. Previously this was done by the `_get_funcname_and_args()` helper, but extracting function names was not useful because whenever the helper was called both the C function name and the corresponding `pyerfa` function name were already known. The new `_args_from_func_call()` helper is more useful.
avalentino
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Among other things
erfa_generatortranslates ERFA C tests to Python tests, which requires extracting arguments from C function calls. On currentmainthere is the_get_funcname_and_args()helper for that purpose, but extracting function names is not useful because whenever the helper is called both the C function name and the correspondingpyerfafunction name are already known. The new_args_from_func_call()does not bother with function names and allows deduplicating more code than_get_funcname_and_args()ever did. The full difference between theerfa/tests/test_ufunc.pygenerated by currentmainthis PR isIn all cases the removal of whitespace is an improvement.