Simplify generating tests for some arrays - #320
Merged
Conversation
Many `pyerfa` functions return structured arrays so that subarrays can be accessed both by an index or by a named field. So far when `erfa_generator` has translated the ERFA C tests to Python it has in many cases replaced indexing with accessing fields by name, but that has added complexity to `erfa_generator` that can be avoided by using indices like the ERFA C tests do.
avalentino
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many
pyerfafunctions return structured arrays so that subarrays can be accessed both by an index or by a named field. For example:On current
mainthe tests thaterfa_generatorcreates by translating ERFA C code to Python often replace indices with named fields, but the translation is much simpler if the generated tests use indices instead of named fields like the ERFA C tests do. I am not going to paste the difference between theerfa/tests/test_ufunc.pygenerated onmainand in this PR because it is quite large, but I have checked that all the assert statements are still in place and none of the numerical values have changed.