Skip to content

Added support for saving and loading directly into savestate slots 0 through 9#18975

Open
kimimaru4000 wants to merge 1 commit into
libretro:masterfrom
kimimaru4000:MergeDirectSaveLoadStates
Open

Added support for saving and loading directly into savestate slots 0 through 9#18975
kimimaru4000 wants to merge 1 commit into
libretro:masterfrom
kimimaru4000:MergeDirectSaveLoadStates

Conversation

@kimimaru4000

@kimimaru4000 kimimaru4000 commented Apr 24, 2026

Copy link
Copy Markdown

Guidelines

  1. Rebase before opening a pull request
  2. If you are sending several unrelated fixes or features, use a branch and a separate pull request for each
  3. If possible try squashing everything in a single commit. This is particularly beneficial in the case of feature merges since it allows easy bisecting when a problem arises
  4. RetroArch codebase follows C89 coding rules for portability across many old platforms check using C89_BUILD=1

Description

This is a cleaner PR for #13024, as it's been many years since that was last opened. All the changes have been updated and are in one commit.

This PR adds new hotkeys for directly saving and loading into save states.

  • The savestate_max_direct_slot setting determines the highest slot that can be used with the hotkeys. For example, if this value is 1, hotkeys for directly saving and loading slots 0 and 1 can be used. This defaults to -1, which disables the feature.
  • Similarly, the options and bindings for the direct slots won't show up in the Hotkeys menu if the slot is greater than savestate_max_direct_slot.
  • None of the new hotkeys are binded by default.

MaxDirectSaveStateSlot

DirectSaveStates

I've been maintaining and testing this feature for years, and it's been stable and performant.

Related Issues

#12990

Related Pull Requests

[Any other PRs from related repositories that might be needed for this pull request to work]

Reviewers

@LibretroAdmin

@kimimaru4000

kimimaru4000 commented May 11, 2026

Copy link
Copy Markdown
Author

Hi @LibretroAdmin can you please have a look when you have time and let me know what you think? I will fix the new conflict that popped up.

@kimimaru4000 kimimaru4000 force-pushed the MergeDirectSaveLoadStates branch from 1d7cba8 to b0b2d91 Compare June 8, 2026 16:41
@kimimaru4000

Copy link
Copy Markdown
Author

I've fixed the conflicts. May I ask @Splaser @LibretroAdmin @fpscan or another contributor to have a look and inform me if this is good to merge?

@hizzlekizzle

Copy link
Copy Markdown
Collaborator

Hey, sorry for the delay, and thanks again for rebasing on the new codebase. We're looking at it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants