cheats: fall back to content path for game-specific files#19089
Open
Splaser wants to merge 4 commits into
Open
cheats: fall back to content path for game-specific files#19089Splaser wants to merge 4 commits into
Splaser wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime-created cheats may fail to persist when no cheat file has been loaded beforehand.
Game-specific cheat filenames were derived from runloop_st->name.cheatfile only. When a cheat is created from the menu without first loading an existing .cht file, this value can be empty, causing cheat_manager_get_game_specific_filename() to return 0 and preventing the cheat list from being saved.
Fall back to the current content basename/path when no cheatfile name is available, while preserving the existing cheatfile-based behavior when it is set.
Tested on Android aarch64: