x11: Skip announcing WM_TAKE_FOCUS in WM_PROTOCOLS - #16150
Open
zzag wants to merge 1 commit into
Open
Conversation
By putting the WM_TAKE_FOCUS atom in the WM_PROTOCOLS property, SDL chooses either the "Locally Active" or "Globally Active" input model depending on the input flag in WM_HINTS. In order to assist the window manager with making the right decision, for example, skip this window when choosing what window to activate next, it will be better if the WM knows right away that the window accepts or doesn't accept focus (in other words, have either both the input flag set in WM_HINTS + WM_TAKE_FOCUS or none). Since the WM_TAKE_FOCUS atom is placed in the WM_PROTOCOLS property, the WM wanting to adhere to the spec has no choice but send a client message asking to activate the window and hope for the better. At quick glance, it appears that the WM_TAKE_FOCUS atom is leftover from SDL_WINDOWEVENT_TAKE_FOCUS, which was dropped a while ago, and is not used anymore. So this change removes the WM_TAKE_FOCUS atom to help window managers such as kwin work better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By putting the WM_TAKE_FOCUS atom in the WM_PROTOCOLS property, SDL chooses either the "Locally Active" or "Globally Active" input model depending on the input flag in WM_HINTS.
In order to assist the window manager with making the right decision, for example, skip this window when choosing what window to activate next, it will be better if the WM knows right away that the window accepts or doesn't accept focus (in other words, have either both the input flag set in WM_HINTS + WM_TAKE_FOCUS or none).
Since the WM_TAKE_FOCUS atom is placed in the WM_PROTOCOLS property, the WM wanting to adhere to the spec has no choice but send a client message asking to activate the window and hope for the better.
At quick glance, it appears that the WM_TAKE_FOCUS atom is leftover from SDL_WINDOWEVENT_TAKE_FOCUS, which was dropped a while ago, and is not used anymore. So this change removes the WM_TAKE_FOCUS atom to help window managers such as kwin work better.