Fix recovered offset allocation range check

[calculatetech]

Summary

Recovered offset index entries were checked against the allocation map using zero-initialized local offset and size variables instead of the values parsed into the index value. This could reject recoverable entries based on an unrelated range at offset zero.

This change:

• checks the parsed file offset and data size
• keeps negative offsets classified as not recoverable
• adds a focused regression test for ranges inside and outside the unallocated map

Testing

• ./autogen.sh
• ./configure --disable-static --disable-nls
• make -j4
• make check

All 47 library tests, 3 manpage tests, and 3 tool tests pass.

[joachimmetz]

Thanks for the proposed changes, what's up reasoning behind the draft status of this PR?

[calculatetech]

Thanks for the proposed changes, what's up reasoning behind the draft status of this PR?

I'm still learning my way around github. My mistake.

[joachimmetz]

Thanks for the additional context, I'll take a closer look as soon as time permits

[codecov]

Codecov Report

❌ Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.33%. Comparing base (e9b304c) to head (e198d23).

Files with missing lines	Patch %	Lines
libpff/libpff_recover.c	72.72%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   29.20%   29.33%   +0.13%     
==========================================
  Files          64       64              
  Lines       20854    20801      -53     
  Branches     5037     5040       +3     
==========================================
+ Hits         6090     6102      +12     
+ Misses      12818    12743      -75     
- Partials     1946     1956      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.