Skip to content

fix(test): give the contended restore its real production wait budget #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 1 commit into from
Aug 6, 2026
Merged

fix(test): give the contended restore its real production wait budget #1129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/codex-composed-acceptance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,13 @@ describe("WP13 composed toggle acceptance", () => {
`], { cwd: repoRoot, env: fx.env(), stdout: "pipe", stderr: "pipe" });
fx.children.push(holder);
await waitFor(() => existsSync(held) ? true : null, "history BEGIN IMMEDIATE");
const blocked = await fx.runCli(["restore", "--json"], fx.homeA, fx.userprofileA, 15_000);
// The contended restore deliberately waits out PRODUCTION's retry budget:
// a 5 s SQLite busy timeout per attempt, two attempts, plus the delay
// between them — ~11 s of intentional waiting before it can report `busy`.
// A 15 s watchdog left almost no margin and fired on a loaded macOS runner
// (dev CI run 31105071651). Give the wait its budget plus real headroom;
// the case's own 45 s test timeout still bounds it.
const blocked = await fx.runCli(["restore", "--json"], fx.homeA, fx.userprofileA, 30_000);
expect(blocked.exitCode).toBe(1);
const envelope = JSON.parse(blocked.stdout) as { success: boolean; artifacts: { history: { state: string; reason?: string } } };
expect(envelope).toMatchObject({ success: false, artifacts: { history: { state: "failed", reason: "busy" } } });
Expand Down
Loading