Skip to content

fix(windows): hide npm launcher proxy child #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ingwannu wants to merge 1 commit into from
Closed

fix(windows): hide npm launcher proxy child #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bin/ocx.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,10 @@ const launchContext = JSON.stringify({
});
const child = spawn(bun, [cliPath, `${NODE_LAUNCH_PROOF_PREFIX}${launchProof}`, ...process.argv.slice(2)], {
stdio: "inherit",
// A headless Windows parent (Task Scheduler, dashboard restart, shortcut) has no
// console to inherit. Without this flag Windows allocates a visible console for
// the long-running Bun child, and closing that window kills the proxy (#1236).
windowsHide: true,
env: {
...process.env,
[NODE_LAUNCH_CONTEXT_ENV]: launchContext,
Expand Down
11 changes: 11 additions & 0 deletions tests/ocx-launcher-source.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,17 @@ describe("ocx.mjs npm launcher (source invariants)", () => {
expect(runtimeSource).toContain('export const BUN_RUNTIME_SOURCE_ENV = "OCX_BUN_RUNTIME_SOURCE";');
});

test("the long-running Bun child stays hidden under a headless Windows launcher (#1236)", () => {
const spawnStart = source.indexOf("const child = spawn(bun, [cliPath");
expect(spawnStart).toBeGreaterThanOrEqual(0);
const spawnCall = source.slice(spawnStart, source.indexOf("});", spawnStart));

// Scope this to the final Node-to-Bun launch. Other helper spawns already hide
// their windows, but they do not cover the child that owns the proxy lifetime.
expect(spawnCall).toContain('stdio: "inherit"');
expect(spawnCall).toContain("windowsHide: true");
});

test("Windows npm spawns use the trusted absolute invocation without shell lookup", () => {
expect(source).toContain("const latestInvocation = npmInvocation(");
expect(source).toContain("const installInvocation = npmInvocation(");
Expand Down
Loading