Skip to content

fix(gui): keep models tabs aligned - #1423

Closed
iF2007 wants to merge 2 commits into
lidge-jun:devfrom
iF2007:fix/models-tabs-layout-drift
Closed

fix(gui): keep models tabs aligned#1423
iF2007 wants to merge 2 commits into
lidge-jun:devfrom
iF2007:fix/models-tabs-layout-drift

Conversation

@iF2007

@iF2007 iF2007 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Before this fix, the Models catalog tab used the wider \1200px\ content layout, while the Routing tab fell back to the default \980px\ layout.
  • As a result, switching between the Models, Combo, and Routing tabs caused visible horizontal page drift (about 36px at a 1294px viewport); similar pages such as Logs and Debug were unaffected.
  • Keep the Models catalog and routing tabs aligned by applying the same visible-panel width rule to both tabs and add regression coverage.

Verification

Tested at head \2f6c19d0\ on top of current \dev\ (\�dd89e66).

  • \�un run typecheck\
  • \�un run privacy:scan\
  • \cd gui && bun test tests/models-provider-head.test.ts tests/models-workspace-panels.test.tsx\ (16 passed, including mounted Catalog -> Routing -> Catalog width regression)
  • \�un run lint:gui\
  • \�un run build:gui\
  • Browser verification at \1294x714: switching between Models, Combo, and Routing keeps the catalog and routing content at the same horizontal position.
  • PR screenshot reviewed: no tokens, account information, local paths, usernames, or private hostnames.

Models routing tab after the layout fix

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • All CI tests are green on my local testing.

  • I pushed my PR to the latest dev commit.

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

Summary by CodeRabbit

  • Bug Fixes

    • Improved the workspace layout so the main content maintains the correct 1200px width when viewing either the catalog or routing tabs.
    • Fixed layout consistency when navigating directly to the routing tab or switching between tabs.
  • Tests

    • Added coverage to verify consistent layout behavior across both tabs and navigation scenarios.

@github-actions github-actions Bot added the intake: hygiene-blocked Deterministic PR hygiene checks failed label Aug 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Deterministic hygiene checks failed.

  • unsponsored_surface — This changes an authentication, workflow, release-automation, or dependency surface. MAINTAINERS.md requires security review for these; ask a maintainer to apply maintainer-sponsored once they have reviewed it. Paths: package.json.

@github-actions github-actions Bot added the bug Something isn't working label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7d2f11f2-5cca-4cc3-9af2-fa163eec3d4f

📥 Commits

Reviewing files that changed from the base of the PR and between b28410b and 2f6c19d.

📒 Files selected for processing (1)
  • gui/tests/models-workspace-panels.test.tsx

📝 Walkthrough

Walkthrough

The Models workspace CSS applies the 1200px .main-inner width when the catalog or routing panel is visible. Tests cover the shared selector, tab switching, and direct routing visits.

Changes

Models workspace layout

Layer / File(s) Summary
Shared panel layout and selector coverage
gui/src/styles-models-workspace.css:11-21, gui/tests/models-provider-head.test.ts:34-44
The .main-inner rule targets visible catalog or routing panels without requiring the catalog workspace shell. The CSS test verifies both selectors.
Tab layout regression coverage
gui/tests/models-workspace-panels.test.tsx:94-188
Test helpers mount Models, inject the page-width CSS, read computed width, and switch tabs. Tests cover tab changes and direct routing visits while inactive panels remain mounted and hidden.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: review-ready

Suggested reviewers: ingwannu, lidge-jun

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: keeping the Models catalog and Routing tabs aligned through a shared layout rule.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

✅ READY

  • all PR quality gates passed; the review readiness checklist is complete.

Review readiness checklist

  • ✅ All CI tests are green on my local testing.
  • ✅ I pushed my PR to the latest dev commit.
  • ✅ I resolved all correct Codex and CodeRabbit findings.
  • ✅ My PR is ready for review.

4/4 boxes ticked.

This pull request is already Ready for Review.
The review-ready label marks this PR as ready; review automation runs independently. If no CodeRabbit review appears, comment @coderabbitai review to request one.
Maintainers: @lidge-jun @Ingwannu @Wibias

@github-actions
github-actions Bot marked this pull request as draft August 10, 2026 11:33
@iF2007
iF2007 force-pushed the fix/models-tabs-layout-drift branch from 9191097 to b28410b Compare August 10, 2026 11:36
@github-actions github-actions Bot added review-ready and removed intake: hygiene-blocked Deterministic PR hygiene checks failed labels Aug 10, 2026
@github-actions
github-actions Bot marked this pull request as ready for review August 10, 2026 11:40
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@github-actions[bot] Acknowledged. The PR is marked Ready for Review, and the reported readiness checklist is complete.

I am replying to the latest comment only. I do not have the full earlier comment chain.

You are interacting with an AI system.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@github-actions[bot] The PR is marked ready for review. I will review the current changes. I am replying to the latest comment only because the complete earlier comment chain is unavailable.

⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@github-actions The PR readiness gate is complete. The pull request is already Ready for Review.

You are interacting with an AI system.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@github-actions[bot] Acknowledged. The readiness checklist is complete, and the pull request is Ready for Review.

You are interacting with an AI system.

iF2007 and others added 2 commits August 11, 2026 00:59
Rebase onto latest dev and assert catalog/routing share the same main-inner max-width across tab switches, including a direct routing visit with a hidden mounted catalog panel.
@Wibias
Wibias force-pushed the fix/models-tabs-layout-drift branch from b28410b to 2f6c19d Compare August 10, 2026 23:06
@github-actions
github-actions Bot marked this pull request as draft August 10, 2026 23:06
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@github-actions The PR readiness checklist and deterministic hygiene checks are complete. The pull request remains Ready for Review.

You are interacting with an AI system.

@github-actions
github-actions Bot marked this pull request as ready for review August 10, 2026 23:07
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@github-actions[bot] Acknowledged. The PR is Ready for Review. The readiness checklist is complete, and all reported quality gates passed.

You are interacting with an AI system.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@github-actions[bot] Acknowledged. The quality gates passed, the readiness checklist is complete, and PR #1423 is Ready for Review.

You are interacting with an AI system.

@Wibias

Wibias commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks for your contribution. Since I am already working on the ui, i will be closing this.

@Wibias Wibias closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working review-ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants