fix(google): keep thought parts out of visible text - #1518
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
Thanks for carrying this forward. I compared the patch against #1508: the Google adapter, regression tests, and structure note are the same 3-file |
Summary
thought: trueout of ordinary assistant text in both SSE and buffered JSON parsing.reasoning_raw_deltawhile preserving ordinary text, function-call ordering, inline images, and Antigravity/Vertex thought-signature observation.Verification
bun run typecheck— passed.bun test tests/google-hardening.test.ts tests/google-antigravity-wire.test.ts tests/google-vertex-thought-signature.test.ts— 81 passed, 0 failed.bun run privacy:scan— passed.origin/devat the time of push.Checklist
devcommit.Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.