test(codex-convergence): update route inventory for #1541's attested reload call

[RobinBially]

Problem

dev CI is currently red for every open PR: #1541 (fb4f2fe99) added a seventh await convergeCodexCatalog() to src/server/management/provider-routes.ts in the new attested credential-free provider-reload route, but tests/codex-convergence-contract.test.ts ("route inventory contains exactly the specified 6 + 6 + 2 + 2 convergence calls") still expects 6. See the analysis on #1500 where the failure surfaced on the merge ref, and @Wibias's confirmation that the stale inventory contract should be repaired on dev before merging.

Fix

Update the inventory contract to the actual call set: expected count for provider-routes.ts 6 → 7 in both the map and the final toEqual, and the test title to 7 + 6 + 2 + 2. The seventh call is legitimate — the attested reload route converges the catalog after clearing provider caches, same as every sibling route — so the contract is updated rather than the call removed.

Tests

bun test tests/codex-convergence-contract.test.ts — 12 pass / 0 fail on this branch (dev @ 6c5f94a13 + this commit).

Unblocks #1500.

🤖 Generated with Claude Code

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

• All CI tests are green on my local testing.

• I pushed my PR to the latest dev commit.

• I resolved all correct Codex and CodeRabbit findings.

• My PR is ready for review.

Summary by CodeRabbit

• Tests
  • Updated route inventory validation to reflect the current number of convergence calls and expected route totals.

[github-actions]

✅ Deterministic PR hygiene checks passed.

[github-actions]

✅ READY

• all PR quality gates passed; the review readiness checklist is complete.

Review readiness checklist

• ✅ All CI tests are green on my local testing.
• ✅ I pushed my PR to the latest dev commit.
• ✅ I resolved all correct Codex and CodeRabbit findings.
• ✅ My PR is ready for review.

✅ 4/4 boxes ticked.

This pull request is already Ready for Review.
The review-ready label marks this PR as ready; review automation runs independently. If no CodeRabbit review appears, comment @coderabbitai review to request one.
Maintainers: @lidge-jun @Ingwannu @Wibias

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ab127392-2721-4498-b58a-8af865d5ac1c

📥 Commits

Reviewing files that changed from the base of the PR and between 6c5f94a and dccbd38.

📒 Files selected for processing (1)

• tests/codex-convergence-contract.test.ts

---

📝 Walkthrough

Walkthrough

The route inventory contract test now expects seven convergence calls in provider-routes.ts. The aggregate expected route count changes from 6 + 6 + 2 + 2 to 7 + 6 + 2 + 2.

Changes

Convergence contract

Layer / File(s)	Summary
Update convergence route counts tests/codex-convergence-contract.test.ts	The test description, per-file expectation, and aggregate count now require seven convergence calls in provider-routes.ts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: wibias, ingwannu, lidge-jun

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the test update and the route inventory change caused by PR #1541's attested reload call.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

@github-actions[bot] The latest readiness-gate status reports that PR #1554 is ready for review. The checklist is complete, and the review-ready label is present.

---

🧠 Learnings used

Learnt from: Wibias
Repo: lidge-jun/opencodex PR: 986
File: .github/workflows/enforce-pr-target.yml:631-636
Timestamp: 2026-08-04T06:41:30.089Z
Learning: For the PR readiness gate in `.github/workflows/enforce-pr-target.yml`, the required scope is to bind contributor checklist completion and maintainer notification to the exact PR head SHA, then reset them after a new head commit. Maintainer approval staleness is separate from this gate and should be enforced by GitHub branch protection, such as `dismiss-stale-reviews` or `require_last_push_approval`, when configured for `dev`.

_{You are interacting with an AI system.}

[coderabbitai]

@github-actions[bot] The readiness gate is complete for PR #1554. I will review the current head commit.

---

🧠 Learnings used

Learnt from: Wibias
Repo: lidge-jun/opencodex PR: 986
File: .github/workflows/enforce-pr-target.yml:631-636
Timestamp: 2026-08-04T06:41:30.089Z
Learning: For the PR readiness gate in `.github/workflows/enforce-pr-target.yml`, the required scope is to bind contributor checklist completion and maintainer notification to the exact PR head SHA, then reset them after a new head commit. Maintainer approval staleness is separate from this gate and should be enforced by GitHub branch protection, such as `dismiss-stale-reviews` or `require_last_push_approval`, when configured for `dev`.

⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.