Feat: Move link implementation to the interactive session module#318
Draft
l-mansouri wants to merge 7 commits into
Draft
Feat: Move link implementation to the interactive session module#318l-mansouri wants to merge 7 commits into
l-mansouri wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR moves the link command implementation to the interactive session module and changes the
--mountoption of cloudos interactive-session to--link --copyJIRA
https://lifebit.atlassian.net/browse/LP-110779
Changes
cloudos linkinto theinteractive-sessionmodule ascloudos interactive-session linkmy-project/Data/folder); standard top-level folder names (Data,AnalysesResults,Analyses_Results,Analyses-Results,Cohorts) are treated as relative to the profile project--mountfromcloudos interactive-session create--copyas an optional flag of--linkincloudos interactive-session createto copy data into the sessionAcceptance Criteria
Scenario 1: cloudos interactive-session link replaces cloudos link with identical functionality
Scenario 2: create --link links a folder or file to the interactive session
Scenario 3: create --link --copy copies data into the interactive session
Scenario 4: Files are linkable via cloudos interactive-session link if supported by the DEV endpoint
Scenario 5: Detailed API error messages are surfaced to the user on failure