docs: update 8-14-expense-reports to match backend#349
Open
light-cmd wants to merge 1 commit into
Open
Conversation
The article described expense analytics dashboards, compliance reports, scheduled reports, and benchmarking that do not exist in the product. Rewritten to describe expense reports as reimbursement submissions and point spend analysis at the actual ledger reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verified
articles/08-expense-management/8-14-expense-reports.mdagainst the backend monolith. The article described an expense analytics suite that does not exist in the product, so it has been rewritten to describe the actual feature.Discrepancies found
The article documented the following features, none of which exist in the backend (no matching BFF resources, REST endpoints, or modules):
What the backend actually supports
ExpenseV1ResourcePOST /expenses/submit,ReimbursementDto.expenseIds)/expenses); finance reviews via Reimbursements (/reimbursements,BffReimbursementV1Resource)/ledger-reports,LedgerReportV1Resource): Balance Sheet, Cash Flow Statement, General Ledger, Income Statement, Trial Balance, VAT (ReportDefinitionSystemName), plus pivot table reportsCsvExportV1Resource, GL report export); no Excel/PDF report exportChanges
help-article-hierarchy.mdaccordingly