play a short ding sound when generation or workflow run completes#209
Open
iammojogo-sudo wants to merge 1 commit into
Open
play a short ding sound when generation or workflow run completes#209iammojogo-sudo wants to merge 1 commit into
iammojogo-sudo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a generation (image-to-3D or a multi-node workflow), the app currently gives no audible feedback when it finishes. If you're in another tab or just looking away, there's no way to know it's done without checking back.
This PR adds a short, unobtrusive 880Hz "ding" sound (think microwave or oven beep) played once when:
A single image-to-3D generation finishes
A workflow run finishes (all branches complete)
The sound is generated on the fly using the Web Audio API — no audio files to bundle, no new dependencies, works in any modern browser/Electron environment. If audio isn't available for some reason, it silently does nothing.
Changes are minimal: a new utility file (src/shared/utils/sound.ts) and one line each in useGeneration.ts and workflowRunStore.ts.