Skip to content

docs: sync CNY_ACCOUNT support with OpenAPI schema#555

Open
claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20260606
Open

docs: sync CNY_ACCOUNT support with OpenAPI schema#555
claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20260606

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude Bot commented Jun 6, 2026

Summary

  • Add CNY_ACCOUNT to Grid Visualizer data files (account-types.ts, currencies.ts)
  • Move China from "Coming Soon" to supported countries in country-support.mdx
  • Update Asia-Pacific region count from 9 to 10 countries

Syncs documentation and visualizer with CNY_ACCOUNT addition in #552.

Test plan

  • Grid Visualizer renders CNY as a fiat destination option
  • Country support table shows China with Bank Transfer rail
  • Regional summary shows 10 countries for Asia-Pacific

🤖 Generated with Claude Code

Add CNY_ACCOUNT to Grid Visualizer data files and update country
support documentation to reflect China support added in #552.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented Jun 6, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🟢 Ready View Preview Jun 6, 2026, 9:02 AM

@claude claude Bot requested review from pengying and shreyav June 6, 2026 09:00
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment Jun 6, 2026 9:00am

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 6, 2026

Greptile Summary

This PR syncs the Grid Visualizer and country-support docs with the CNY_ACCOUNT type introduced in #552, adding China's CNY currency entry and moving China from "Coming Soon" to the supported countries table.

  • account-types.ts gains a CNY_ACCOUNT spec with phoneNumber + bankName fields — consistent with CnyAccountInfoBase.yaml.
  • currencies.ts and country-support.mdx label China's payment rail as Bank Transfer, but the OpenAPI schema (CnyAccountInfo.yaml) restricts paymentRails to MOBILE_MONEY only, creating a documentation/API mismatch that will mislead integrators.
  • Asia-Pacific regional count is correctly updated from 9 to 10.

Confidence Score: 3/5

The docs and visualizer contradict the API schema on the payment rail for China, which will directly mislead integrators building CNY payout flows.

The currencies.ts and country-support.mdx both advertise Bank Transfer for CNY payments, but CnyAccountInfo.yaml restricts paymentRails to MOBILE_MONEY. A developer reading the docs would expect to construct a bank-transfer flow, then hit an API validation error at runtime. The account-types.ts change is clean and matches the schema.

currencies.ts and country-support.mdx — the rail label needs to align with the API schema before this goes live.

Important Files Changed

Filename Overview
components/grid-visualizer/src/data/account-types.ts Adds CNY_ACCOUNT spec with phoneNumber and bankName fields, matching CnyAccountInfoBase.yaml exactly.
components/grid-visualizer/src/data/currencies.ts Adds CNY currency entry but labels allRails as 'Bank Transfer', conflicting with the OpenAPI schema which restricts paymentRails to MOBILE_MONEY.
mintlify/snippets/country-support.mdx Moves China from Coming Soon to supported, updates Asia-Pacific count to 10 (correct), but lists the payment rail as 'Bank Transfer' which contradicts the API schema (MOBILE_MONEY).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR #555: Add CNY_ACCOUNT docs] --> B[account-types.ts
phoneNumber + bankName fields]
    A --> C[currencies.ts
allRails: Bank Transfer ⚠️]
    A --> D[country-support.mdx
China: Bank Transfer ⚠️]
    B --> E[Matches CnyAccountInfoBase.yaml ✅]
    C --> F[CnyAccountInfo.yaml
paymentRails: MOBILE_MONEY only ❌ mismatch]
    D --> F
Loading
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
mintlify/snippets/country-support.mdx:27
**Payment rail label contradicts the OpenAPI schema**

The OpenAPI schema for `CnyAccountInfo` (`openapi/components/schemas/common/CnyAccountInfo.yaml`) restricts `paymentRails` to a single enum value: `MOBILE_MONEY`. The account fields (`phoneNumber` + `bankName`) also match a phone-based mobile-money flow (consistent with WeChat Pay / Alipay), not a conventional direct bank transfer. Listing China here as `Bank Transfer` will mislead developers who then find the API only accepts `MOBILE_MONEY` as the payment rail. The same mismatch exists in `currencies.ts` (`allRails: ['Bank Transfer']`).

### Issue 2 of 2
components/grid-visualizer/src/data/currencies.ts:274-276
The OpenAPI schema (`CnyAccountInfo.yaml`) restricts `paymentRails` to `MOBILE_MONEY` only, so labelling the rail as `Bank Transfer` here is inconsistent with the API contract. The label should reflect the actual underlying rail (mobile money via WeChat Pay / Alipay) to avoid confusing integrators.

```suggestion
    instantRails: [],
    allRails: ['Mobile Money'],
    examplePerson: { fullName: 'Wei Zhang', nationality: 'CN' },
```

Reviews (1): Last reviewed commit: "docs: sync CNY_ACCOUNT support with Open..." | Re-trigger Greptile

| 🇧🇷 Brazil | BR | `PIX` |
| 🇧🇬 Bulgaria | BG | `SEPA` `SEPA Instant` |
| 🇨🇲 Cameroon | CM | `Bank Transfer` |
| 🇨🇳 China | CN | `Bank Transfer` |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Payment rail label contradicts the OpenAPI schema

The OpenAPI schema for CnyAccountInfo (openapi/components/schemas/common/CnyAccountInfo.yaml) restricts paymentRails to a single enum value: MOBILE_MONEY. The account fields (phoneNumber + bankName) also match a phone-based mobile-money flow (consistent with WeChat Pay / Alipay), not a conventional direct bank transfer. Listing China here as Bank Transfer will mislead developers who then find the API only accepts MOBILE_MONEY as the payment rail. The same mismatch exists in currencies.ts (allRails: ['Bank Transfer']).

Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/snippets/country-support.mdx
Line: 27

Comment:
**Payment rail label contradicts the OpenAPI schema**

The OpenAPI schema for `CnyAccountInfo` (`openapi/components/schemas/common/CnyAccountInfo.yaml`) restricts `paymentRails` to a single enum value: `MOBILE_MONEY`. The account fields (`phoneNumber` + `bankName`) also match a phone-based mobile-money flow (consistent with WeChat Pay / Alipay), not a conventional direct bank transfer. Listing China here as `Bank Transfer` will mislead developers who then find the API only accepts `MOBILE_MONEY` as the payment rail. The same mismatch exists in `currencies.ts` (`allRails: ['Bank Transfer']`).

How can I resolve this? If you propose a fix, please make it concise.

Comment on lines +274 to +276
instantRails: [],
allRails: ['Bank Transfer'],
examplePerson: { fullName: 'Wei Zhang', nationality: 'CN' },
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The OpenAPI schema (CnyAccountInfo.yaml) restricts paymentRails to MOBILE_MONEY only, so labelling the rail as Bank Transfer here is inconsistent with the API contract. The label should reflect the actual underlying rail (mobile money via WeChat Pay / Alipay) to avoid confusing integrators.

Suggested change
instantRails: [],
allRails: ['Bank Transfer'],
examplePerson: { fullName: 'Wei Zhang', nationality: 'CN' },
instantRails: [],
allRails: ['Mobile Money'],
examplePerson: { fullName: 'Wei Zhang', nationality: 'CN' },
Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/currencies.ts
Line: 274-276

Comment:
The OpenAPI schema (`CnyAccountInfo.yaml`) restricts `paymentRails` to `MOBILE_MONEY` only, so labelling the rail as `Bank Transfer` here is inconsistent with the API contract. The label should reflect the actual underlying rail (mobile money via WeChat Pay / Alipay) to avoid confusing integrators.

```suggestion
    instantRails: [],
    allRails: ['Mobile Money'],
    examplePerson: { fullName: 'Wei Zhang', nationality: 'CN' },
```

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants