Update deprecated OAuth scopes and stale docs URLs#16
Open
ZLeventer wants to merge 1 commit intolinkedin-developers:mainfrom
Open
Update deprecated OAuth scopes and stale docs URLs#16ZLeventer wants to merge 1 commit intolinkedin-developers:mainfrom
ZLeventer wants to merge 1 commit intolinkedin-developers:mainfrom
Conversation
- config.properties: replace r_emailaddress, r_liteprofile, rw_ads, rw_organization_admin (all deprecated) with current OpenID Connect scopes: openid, profile, email, w_member_social - LinkedInMarketingController.java: update Marketing API scope comment (rw_ads → r_ads, w_ads) and fix docs.microsoft.com URLs to learn.microsoft.com (the current canonical domain) Fixes: deprecated scopes cause an authorization error on the OAuth consent screen; see https://i.imgur.com/Nfz0u2y.png
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #13.
Problem
Two files still reference deprecated LinkedIn OAuth scopes that cause a hard authorization error on the OAuth consent screen (screenshot: https://i.imgur.com/Nfz0u2y.png), and both documentation URLs point to
docs.microsoft.comwhich no longer resolves to the correct pages.Changes
server/src/main/resources/config.propertiesReplaces all four deprecated scopes with their current equivalents:
r_emailaddressemailr_liteprofileprofilerw_adsrw_organization_adminThe default config now uses the standard OpenID Connect product scopes (
openid,profile,email,w_member_social) which work without additional product approval.server/src/main/java/com/example/api/LinkedInMarketingController.javarw_ads→r_ads, w_ads;rw_organization_adminis replaced by granular scopes in the Marketing Developer Platformdocs.microsoft.comURLs →learn.microsoft.com(the current canonical domain for LinkedIn API docs)