Fix: guard against None elements in BatchCreateResponseFormatter#70
Open
ZLeventer wants to merge 1 commit intolinkedin-developers:mainfrom
Open
Fix: guard against None elements in BatchCreateResponseFormatter#70ZLeventer wants to merge 1 commit intolinkedin-developers:mainfrom
ZLeventer wants to merge 1 commit intolinkedin-developers:mainfrom
Conversation
…g from batch create response When the JSON response lacks an "elements" key, json_data.get() returns None, which cannot be iterated. Default to an empty list instead, matching the pattern already used by BatchFinderResponseFormatter. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BatchCreateResponseFormatter.format_response()crashes withTypeErrorwhenelementskey is absent from the JSON responsejson_data.get("elements", None)returnsNone, which is then iterated in a list comprehensionbatch_create_resultsdefaults to[]whenelementsisNoneBatchFinderResponseFormatterin the same fileTest plan
elementskeyTypeErroris raised and an empty list is returned forbatch_create_resultselementspresent are unchanged