CI: bump actions/upload-artifact from v3 to v4 - #258
Merged
Conversation
GitHub has fully retired actions/upload-artifact@v3 and now auto-fails any job that references it at the 'Prepare all required actions' step, before any code runs. Every test workflow on 1.2.x pins v3, so all test jobs fail immediately on every PR. Bump all references to @v4, matching what the openhouse-1.5.2 branch already ships (green CI). The upload steps are guarded by if: failure()/always() with a static artifact name, so v4's unique-name-per-run requirement does not apply in practice. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/upload-artifact@v3and now auto-fails any job that references it at the "Prepare all required actions" step — before any code runs. Every test workflow on1.2.xpins@v3, so all test jobs fail in ~2s on every PR to this branch (e.g. ORC: bind struct fields by Iceberg field id in generic and Spark 3.1 readers #256).actions/upload-artifact@v3→@v4across the workflows (13 refs in 8 files), unblocking CI fork-wide for1.2.x.openhouse-1.5.2branch already ships (its CI is green). The upload steps are guarded byif: failure()/always()with a static artifact name, so v4's unique-name-per-run requirement does not apply in practice.Files:
java-ci,spark-ci,flink-ci,hive-ci,delta-conversion-ci,api-binary-compatibility,jmh-benchmarks,recurring-jmh-benchmarks. Nodownload-artifactis used, so nothing else needed.Testing Done
Verified
openhouse-1.5.2already uses@v4with green CI; this makes1.2.xmatch. Root cause was confirmed by inspecting a failing job log on #256 (This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3) and by a retrigger reproducing the identical instant failure.Dependencies
1.2.x.Made with Cursor