Spark 3.1: fill ORC initial defaults on the row reader - #262
Closed
cbb330 wants to merge 1 commit into
Closed
Conversation
Wire the Spark 3.1 row ORC reader to materialize a field's initial-default when it is absent from an id-bearing file, reusing BaseDataReader's constant converter. Co-authored-by: Cursor <cursoragent@cursor.com>
7 tasks
Collaborator
Author
|
Closing: this was based on the wrong branch ( Rebuilt as a clean 2-PR stack on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initial-defaultwhen it is absent from an id-bearing file, reusingBaseDataReader's constant converter.Stack (bottom -> top)
1.2.x)chbush/orc-id-binding-backport)chbush/orc-column-default-api)chbush/orc-initial-default-orc-fill)Depends on #261 (and transitively #260, #256). Review this PR's own delta against its base branch
chbush/orc-initial-default-orc-fill.Supported scope
Vectorized ORC, other Spark/Flink readers, and predicate pushdown on omitted default columns remain deferred.
Testing Done
Tests generated with unit-tests plugin
Made with Cursor