refactor(load-biaser): Remove unused retry-after hint caching#4571
Open
adleong wants to merge 2 commits into
Open
refactor(load-biaser): Remove unused retry-after hint caching#4571adleong wants to merge 2 commits into
adleong wants to merge 2 commits into
Conversation
Signed-off-by: Alex Leong <alex@buoyant.io>
cratelyn
approved these changes
Jun 12, 2026
cratelyn
left a comment
cratelyn
left a comment
Member
There was a problem hiding this comment.
this looks good to me, but i believe that @unleashed should approve this as the author of the underlying code in question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The load biaser uses
CachedRateLimitHintto cache retry-after hints from a response in the response extension metadata. However, the only place this is ever read is immediately after caching it. Therefore, we can simplify by skipping the caching altogether and just using the value directly after it's parsed.This also allows us to get rid of
CachedRateLimitHintentirely.