fix(profile): Add nil check to profile validation#15325
Merged
Conversation
* Add nil check to spec routes in the service profile. * Add test with nil route yaml.
adleong
reviewed
May 28, 2026
adleong
left a comment
adleong
left a comment
Member
There was a problem hiding this comment.
Awesome! There are a few more places in this codepath that are vulnerable to nil pointer dereferences that we should clean up also:
Both ValidateRequestMatch and ValidateResponseMatch take pointers as input and call themselves recursively but don't guard against calling with a nil pointer.
| return fmt.Errorf("ServiceProfile %q has a route with an invalid condition: %w", serviceProfile.Name, err) | ||
| } | ||
| for _, rc := range route.ResponseClasses { | ||
| if rc.Condition == nil { |
Member
There was a problem hiding this comment.
I think we have the same issue here if rc is nil, this will panic.
…into raykroeker/profile-nil-pointer
* Check for nil: response class, request match for any/all, response match for any/all * Add tests to cover each. * Update existing wording to state 'null' vs 'nil'
Contributor
Author
|
@adleong All nil pointers should be covered now. Thanks for the review. |
adleong
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raymond Kroeker raymond@buoyant.io