Skip to content

Remove conditional compilation for .NET Framework #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove conditional compilation for .NET Framework #96

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bae08c7
Initial commit with task details for issue #28
konard Sep 14, 2025
cb9f18e
Remove conditional compilation for .NET Framework
konard Sep 14, 2025
b4c5bd5
Remove CLAUDE.md - Claude command completed
konard Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions csharp/Platform.Disposables.Tests/DisposableTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ private static ProcessStartInfo CreateProcessStartInfo(string logPath, bool wait
return new ProcessStartInfo
{
FileName = "dotnet",
Arguments = $"run -p \"{projectPath}\" -f net7 \"{logPath}\" {waitForCancellation.ToString()}",
Arguments = $"run -p \"{projectPath}\" -f net8 \"{logPath}\" {waitForCancellation.ToString()}",
UseShellExecute = false,
CreateNoWindow = true
};
Expand All @@ -67,11 +67,7 @@ private static string GetDisposalObjectTestProjectFilePath()
}
}
pathParts = newPathParts.ToArray();
#if NET472
var directory = string.Join(Path.DirectorySeparatorChar.ToString(), pathParts.ToArray());
#else
var directory = Path.Combine(pathParts);
#endif
var path = Path.Combine(directory, $"{disposalOrderTestProjectName}.csproj");
if (!Path.IsPathRooted(path))
{
Expand Down
Loading