Skip to content

Add EVM account search classification#6

Open
YoshiyukiSakura wants to merge 1 commit into
cross-agentfrom
worktree/task_425fda3c7e3f4ac2
Open

Add EVM account search classification#6
YoshiyukiSakura wants to merge 1 commit into
cross-agentfrom
worktree/task_425fda3c7e3f4ac2

Conversation

@YoshiyukiSakura
Copy link
Copy Markdown

@YoshiyukiSakura YoshiyukiSakura commented May 19, 2026

Refs #1

Change:

  • Add EVM account search classification so EVM account addresses are handled explicitly in scan search classification.
  • Add test coverage for the EVM account address case.

Objective Evidence:

  • go test ./util/address passed: 8 tests passed in 1 package.
  • go test ./util/address ./internal/server/http was attempted. ./internal/server/http failed during package init because ../../../configs/config.yaml is missing in this local worktree; no assertion failure was reached.

Visual Evidence:

  • n.a. Backend search classification change; no rendered UI session was available in this recovery path.

Reviewer:

  • Manual operator recovery after CrossAgent GitHub App push failed with 403.

Risks / Not Covered:

  • Full HTTP router package test still needs a populated configs/config.yaml fixture/environment.

@crossagent-production-app
Copy link
Copy Markdown

crossagent-production-app Bot commented May 19, 2026

Delivery Evidence Summary

Change:

  • Added explicit EVM/H160 account classification for /api/scan/check_hash so a valid EVM address returns hash_type evm_account.
  • Added regression coverage for 0xdE644936D5B7d5d42032fd08bbA42Fbbfd6663Bc.

Objective Evidence:

  • go test ./util/address -run TestVerifyEthereumAddress -count=1 exit code 0, passed: Ethereum address regression coverage passed.
  • npx -y playwright test --config "$PWD/tmp/evidence/playwright.config.cjs" --reporter=line exit code 0, passed: Evidence render check passed and produced tmp/evidence/evm-search-classification-screenshot.png.

Visual Evidence:

  • EVM account search classification evidence

Reviewer:

  • Evidence Publisher checked the PR diff and validation evidence for this delivery package; changed files are internal/server/http/scan.go and util/address/address_test.go.

Risks / Not Covered:

  • Full HTTP router package integration coverage requires configs/config.yaml and database bootstrap in this worktree.
  • Evidence here covers the EVM address validator branch and browser-rendered final evidence state.

Generated at: 2026-05-19T09:17:36.813Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants