Hosted-agents: first-cut agentName changes#835
Open
shawnyang-coder wants to merge 2 commits intomainfrom
Open
Conversation
|
|
shawnyang-coder
commented
Apr 27, 2026
| Action: createAgent, | ||
| Before: createAgentClient, | ||
| Flags: []cli.Flag{ | ||
| agentNameFlag(true), |
Author
There was a problem hiding this comment.
For Create and Deploy, I made the flag required. The intention is to force the migration.
shawnyang-coder
commented
Apr 27, 2026
| k8s.io/apimachinery v0.34.1 | ||
| ) | ||
|
|
||
| replace github.com/livekit/server-sdk-go/v2 => ../server-sdk-go |
Author
There was a problem hiding this comment.
I need this line to build locally since this change spans multiple repos. How do I merge the PRs so that the two repos do not break each other during the interim? @yoonsio @real-danm
Author
There was a problem hiding this comment.
I think we will need to merge the server-sdk-go PR first. Cut a release. Then update the go.mod here to point to that release right? But what about those livekit-cli used in the field?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.