Hosted agents: add agent name to proto#1520
Open
shawnyang-coder wants to merge 4 commits intomainfrom
Open
Conversation
|
shawnyang-coder
force-pushed
the
shyang-agent-name
branch
from
69975d4 to
4ff3ed3
Compare
shawnyang-coder
force-pushed
the
shyang-agent-name
branch
from
853ddaf to
72818fc
Compare
shawnyang-coder
force-pushed
the
shyang-agent-name
branch
from
bc5a963 to
d794936
Compare
shawnyang-coder
force-pushed
the
shyang-agent-name
branch
from
10f2a18 to
eb5d892
Compare
real-danm
reviewed
Apr 28, 2026
| string agent_id = 1 [(logger.name) = "agentID"]; | ||
| string agent_name = 2 [deprecated=true]; | ||
| reserved 2; | ||
| reserved "agent_name"; |
Contributor
There was a problem hiding this comment.
why the different format here than the others?
Author
There was a problem hiding this comment.
reserved is to make sure we don't use agent_name. it's stronger than deprecated.
It's what we want for Deploy.
real-danm
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.