E2E Test: data channel send/receive test.#647
Open
cloudwebrtc wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end pytests for LiveKit's data-channel (
publish_data) routing semantics, covering targeted delivery, broadcast, topic propagation, and topic-on-targeted sends. Each scenario uses dedicatedrtc.Roominstances per participant and asserts that only the intended receivers see the packet.test_data_one_to_onedestination_identities=["receiver"]reaches onlyreceiver; bystander gets nothing.test_data_one_to_many_targeteddestination_identities=["r1", "r2"]reaches both; an excluded participant gets nothing.test_data_broadcastdestination_identitiesfan-outs to every other participant in the room.test_data_topic_passthroughtopicis preserved end-to-end; receiver-side filtering by topic works.test_data_targeted_with_topictopic; non-targets receive nothing.Implementation notes:
_DataCollectorsubscribes todata_receivedand (optionally) filters by sender identity, so cross-test packet noise is impossible._ensure_visiblewaits until the sender's room state lists the target identities — without this, targeted publishes can race the participant-joined signal and silently drop._assert_no_datauses a 1s settle window before asserting absence, to avoid false negatives from in-flight delivery.Requires
LIVEKIT_URL,LIVEKIT_API_KEY,LIVEKIT_API_SECRETenv vars (tests are auto-skipped otherwise).Test plan
pytest livekit-rtc/tests/test_dc.py -vpasses against a current LiveKit server (verified locally on1.10.1).tests/suite.