Skip to content

Fix drag and drop in codeplug layout creation #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
livitup merged 3 commits into from
Dec 18, 2025
Merged

Fix drag and drop in codeplug layout creation #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e4f2d0
Fix drag and drop in codeplug layout creation
cmi-andrewo Dec 18, 2025
f7924b2
Add spacing between duplicate badge and field path text
cmi-andrewo Dec 18, 2025
3540af3
Make drop zone fill entire card body for easier drag-and-drop
cmi-andrewo Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/javascript/controllers/field_picker_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ export default class extends Controller {
if (headerCounts[header] > 1) {
field.classList.add("border-warning")
const warning = document.createElement("span")
warning.className = "duplicate-warning badge bg-warning text-dark ms-2"
warning.className = "duplicate-warning badge bg-warning text-dark ms-2 me-2"
warning.textContent = "Duplicate"
headerInput.after(warning)
}
Expand Down
32 changes: 30 additions & 2 deletions app/views/codeplug_layouts/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@
</h6>
<small class="text-muted">Drag to reorder</small>
</div>
<div class="card-body">
<div class="layout-builder-container" style="min-height: 200px;">
<div class="card-body d-flex flex-column">
<div class="layout-builder-container flex-grow-1 d-flex flex-column">
<div class="list-group" data-field-picker-target="layoutBuilder">
<%# Layout fields will be rendered by JavaScript %>
</div>
Expand Down Expand Up @@ -168,6 +168,34 @@
max-width: 200px;
}

/* Make the list-group fill the entire card body for easier dropping */
.layout-builder-container .list-group {
flex: 1;
min-height: 150px;
border: 2px dashed #dee2e6;
border-radius: 0.25rem;
padding: 0.5rem;
transition: border-color 0.2s, background-color 0.2s;
}

.layout-builder-container .list-group:empty {
display: flex;
align-items: center;
justify-content: center;
}

/* Highlight the drop zone when dragging over it */
.layout-builder-container .list-group.sortable-ghost-class,
.layout-builder-container .list-group:has(.sortable-ghost) {
border-color: #0d6efd;
background-color: #f8f9ff;
}

.layout-builder-container .list-group:not(:empty) {
border-style: solid;
border-color: #dee2e6;
}

.layout-builder-container .list-group:not(:empty) + .empty-message {
display: none;
}
Expand Down