Skip to content

Fix AIRadar packaging: add missing README and declare real dependencies - #1

Open
egeboy35 wants to merge 1 commit into
lkk688:mainfrom
egeboy35:fix/airadar-packaging
Open

Fix AIRadar packaging: add missing README and declare real dependencies#1
egeboy35 wants to merge 1 commit into
lkk688:mainfrom
egeboy35:fix/airadar-packaging

Conversation

@egeboy35

Copy link
Copy Markdown

Hi! While setting the project up from the root README's Quick Start, step 3 (flit install --symlink in AIRadar/) failed on a fresh clone:

Config error: Description file README.md does not exist

AIRadar/pyproject.toml references readme = "README.md", but the file was not present. The package also declared only numpy as a dependency, while the AIRadarLib modules import scipy, matplotlib, torch, einops, and sklearn — so even a successful install would produce import errors at use time.

Changes

  • Add AIRadar/README.md: a short overview of the AIRadarLib modules plus install instructions.
  • pyproject.toml: declare the dependencies AIRadarLib actually imports, and expose the TensorFlow/Sionna-based helpers as an optional [sionna] extra (they are only used behind lazy imports).
  • Give AIRadarLib/__init__.py a package docstring.

Verification

In a clean venv (Python 3.14):

  • Before: python -m flit buildConfig error: Description file README.md does not exist
  • After: python -m flit buildBuilt sdist: dist/airadarlib-0.1.0.tar.gz + Built wheel: dist/airadarlib-0.1.0-py3-none-any.whl
  • pip install -e . (PEP 660) succeeds and import AIRadarLib works.

Happy to adjust the README wording or the dependency split if you prefer a different structure.

🤖 Generated with Claude Code

'flit install --symlink' (root README Quick Start step 3) fails on a
fresh clone with: "Config error: Description file README.md does not
exist". Add the referenced README with an AIRadarLib module overview
and install notes, declare the dependencies AIRadarLib actually imports
(scipy, matplotlib, torch, einops, scikit-learn), expose the
TensorFlow/Sionna helpers as an optional [sionna] extra, and give
AIRadarLib a package docstring.

Verified: 'python -m flit build' now builds both sdist and wheel.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@egeboy35

Copy link
Copy Markdown
Author

One consequence of this PR I should have spelled out, since it changes what your own documented setup step does.

Adding torch to [project] dependencies makes it a hard install requirement, so the README's flit install --symlink now pulls a multi-gigabyte wheel — including for someone who only wants the classical DSP helpers. Looking at what actually imports what, the split is clean:

  • numpy / scipy / matplotlib only: signal_processing, waveform_utils, channel_simulation, datautil, target_utils, AIradar_autopara, visualization
  • needs torch (plus einops / scikit-learn): modeling_RadarNet, modeling_TimeNet, modeling_transformer, ofdm_decoder, pretrain_dataset, radar_det

So an alternative shape would be core dependencies numpy, scipy, matplotlib with the model side behind an extra, e.g. pip install -e ".[train]" for torch, einops, scikit-learn, keeping the existing [sionna] extra as is. That makes a bare install light and fast, at the cost of one more thing to remember when training.

I deliberately did not do that in this PR, because it changes the install contract rather than just fixing the broken one, and I would rather you decide which you prefer. Happy to push either version — or to leave it exactly as it is if a single install command matters more to you than install size.

Separately, requires-python is still >=3.8 from before this PR; recent torch releases no longer publish 3.8 wheels, so that bound is optimistic now regardless of how the dependencies are grouped.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant