Skip to content

feat(offers): enrich cashout initiated email with customer name, cashout ID, ERPNext link#399

Open
patoo0x wants to merge 1 commit into
mainfrom
eng-409/cashout-email-enrichment
Open

feat(offers): enrich cashout initiated email with customer name, cashout ID, ERPNext link#399
patoo0x wants to merge 1 commit into
mainfrom
eng-409/cashout-email-enrichment

Conversation

@patoo0x

@patoo0x patoo0x commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Closes ENG-409

Changes

EmailService.ts -- wires through cashoutId, customerName (from erpParty), and builds ERPNext link from FrappeConfig.url. Guards against missing username with ?? ''.

cashout.ts template -- added rows:

  • Cashout ID (monospace, copy-friendly)
  • ERPNext Link (clickable URL to /app/cashout/)
  • Customer (primary user identifier, from erpParty)
  • Service Fee (was already in data, now surfaced)
  • Cashout ID in email title and header for inbox preview

Enrichment Summary

Before After
Username undefined risk Guarded with fallback chain
No Cashout ID Cashout ID in title, header, and body
No ERPNext link Clickable link from config
No customer reference erpParty shown as Customer name
No fee data Service fee row visible

…out ID, ERPNext link

- Display ERPNext Customer name (erpParty) as primary identifier
- Add clickable ERPNext link to cashout record via FrappeConfig.url
- Show Cashout ID in header, title, and table row
- Surface service fee row from existing payout data
- Guard against missing username (?? '')
- Fallback: erpParty -> username -> empty string

Closes ENG-409
@linear

linear Bot commented Jun 11, 2026

Copy link
Copy Markdown

ENG-409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants