Skip to content

smitebot: make doctor check failures actionable #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morehouse merged 1 commit into from
Sep 2, 2026
+9 −5
Merged

smitebot: make doctor check failures actionable #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions smitebot/src/commands/doctor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,13 @@ struct DoctorReport {
enum CheckFailure {
#[error("unsupported architecture: {0}")]
UnsupportedArchitecture(String),
#[error("neither vmx nor svm flag found in /proc/cpuinfo")]
#[error(
"neither vmx nor svm flag found in /proc/cpuinfo; enable VT-x (Intel) or AMD-V (AMD) in your BIOS/UEFI settings"
)]
MissingCpuVirtualization,
#[error("{} not found", .0.display())]
MissingPath(PathBuf),
#[error("{} not executable", .0.display())]
#[error("{} not executable; run: chmod +x {}", .0.display(), .0.display())]
NotExecutable(PathBuf),
#[error("{}: {error}", path.display())]
Io {
Expand All @@ -137,7 +139,9 @@ enum CheckFailure {
ToolNotFound(String),
#[error("{command}: {detail}")]
Command { command: String, detail: String },
#[error("libnyx.so not found under --aflpp-path")]
#[error(
"libnyx.so not found under --aflpp-path; rebuild AFL++ with Nyx support (see nyx_mode/README.md in your AFL++ source tree)"
)]
LibnyxNotFound,
#[error("backdoor disabled; run ./scripts/enable-vmware-backdoor.sh to enable")]
VMwareBackdoorDisabled,
Expand Down Expand Up @@ -478,7 +482,7 @@ mod tests {
let err = require_executable(&path).unwrap_err();
assert_eq!(
err.to_string(),
format!("{} not executable", path.display())
format!("{p} not executable; run: chmod +x {p}", p = path.display())
);
}

Expand Down Expand Up @@ -516,7 +520,7 @@ mod tests {
assert_eq!(parsed["checks"][1]["passed"], false);
assert_eq!(
parsed["checks"][1]["reason"],
"neither vmx nor svm flag found in /proc/cpuinfo"
"neither vmx nor svm flag found in /proc/cpuinfo; enable VT-x (Intel) or AMD-V (AMD) in your BIOS/UEFI settings"
);
}

Expand Down