Skip to content

feat(ar/rewayahfans): add روايه فانز plugin - #2306

Open
hamedhani1998 wants to merge 11 commits into
lnreader:masterfrom
hamedhani1998:feat-rewayahfans
Open

feat(ar/rewayahfans): add روايه فانز plugin#2306
hamedhani1998 wants to merge 11 commits into
lnreader:masterfrom
hamedhani1998:feat-rewayahfans

Conversation

@hamedhani1998

Copy link
Copy Markdown
Contributor

Summary

  • Add new Arabic plugin for rewayahfans.net
  • WordPress REST API for novel listing and search
  • Chapter content via WP REST API with HTML fallback

@K1ngfish3r

Copy link
Copy Markdown
Collaborator

the standalone plugin is missing... add the plugin here

@K1ngfish3r

K1ngfish3r commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator
image Picture missing and chapter ordering doesnt seem fine...

parseNovel how-to-be-a-dark-heros-daughter-178

@K1ngfish3r

K1ngfish3r commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator
image is fetching all the pages required?

normal fetch, popular

hamedhani1998 pushed a commit to hamedhani1998/lnreader-plugins that referenced this pull request Jul 18, 2026
…etAllNovels

- Add getCoverUrls() to batch-fetch featured media URLs via WP REST API
- Fix cover images in popularNovels and searchNovels (was always empty)
- Remove getAllNovels() that fetched ALL pages (very slow)
- Simplify popularNovels to use normal paginated API
- Fix chapter ordering in parseNovel (sort always applied)

Addresses reviewer feedback on PR lnreader#2306
@K1ngfish3r

K1ngfish3r commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator
image

parseNovel how-to-survive-as-that-villainess-74
image still missing
chapter 62 seems to have snuck in here
summary (if any) is missing
genres (if any) are missing

@K1ngfish3r

Copy link
Copy Markdown
Collaborator

page 1 and 2 have repeating entries

image image

you can try using adding novel paths to a set, which will record all the paths to ensure no duplicates are pushed

@hamedhani1998
hamedhani1998 force-pushed the feat-rewayahfans branch 2 times, most recently from e6e19c7 to 7af1949 Compare July 21, 2026 07:33
@K1ngfish3r

Copy link
Copy Markdown
Collaborator

I went to the website
https://rewayahfans.net/%D9%82%D8%A7%D8%A6%D9%85%D8%A9-%D8%A7%D9%84%D8%B1%D9%88%D8%A7%D9%8A%D8%A7%D8%AA/
why isnt this used for getting popularNovels? you can just populate them all in one page no? then use search by filtering them. pagination is not required if it is all in one page

@hamedhani1998

Copy link
Copy Markdown
Contributor Author

I went to the website https://rewayahfans.net/%D9%82%D8%A7%D8%A6%D9%85%D8%A9-%D8%A7%D9%84%D8%B1%D9%88%D8%A7%D9%8A%D8%A7%D8%AA/ why isnt this used for getting popularNovels? you can just populate them all in one page no? then use search by filtering them. pagination is not required if it is all in one page

Finsh

@hamedhani1998

Copy link
Copy Markdown
Contributor Author

@K1ngfish3r finsh

@K1ngfish3r

Copy link
Copy Markdown
Collaborator

why merge conflict?
also why public/plugins.json? remove

- WordPress site scraping for novel listing and search
- Cover images from the novels list page
- Chapter listing via REST API with HTML fallback
- parseNovel extracts chapters from novel page directly
- Search filters from cached list
@hamedhani1998

Copy link
Copy Markdown
Contributor Author

@K1ngfish3r All done. Merge conflict resolved, public/plugins.json removed. Ready for review.

@hamedhani1998

Copy link
Copy Markdown
Contributor Author

@K1ngfish3r

@K1ngfish3r

Copy link
Copy Markdown
Collaborator

will chekc in a few hours

@K1ngfish3r

Copy link
Copy Markdown
Collaborator

icon needs to be 96x96
are we not able to get cover, summary, author, genres, status? seem like only name and chapters are obtained

@hamedhani1998

Copy link
Copy Markdown
Contributor Author

icon needs to be 96x96 are we not able to get cover, summary, author, genres, status? seem like only name and chapters are obtained

Icon Fixed & Issue Details for Novels Section

Comment thread plugins/arabic/rewayahfans.ts Outdated
Comment thread plugins/arabic/rewayahfans.ts Outdated
Comment thread plugins/arabic/rewayahfans.ts Outdated
Comment thread plugins/arabic/rewayahfans.ts
Co-authored-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
hamedhani1998 and others added 2 commits July 30, 2026 11:36
- Remove Array<T> in favor of T[]
- Remove unused showLatestNovels param (renamed to _options)
- Set version to 1.0.0
- Add cover, summary, author, genres, status extraction in parseNovel
- Fix genres type: join array to comma-separated string
- Remove development comments
@hamedhani1998

Copy link
Copy Markdown
Contributor Author

All review requests have been addressed and pushed to feat-rewayahfans (commit bd2cb75):

  1. Array<T>T[] (plugins/arabic/rewayahfans.ts:11) — Fixed Array<{ source_url: string }> to { source_url: string }[]
  2. Unused showLatestNovels (plugins/arabic/rewayahfans.ts:69) — Replaced destructured { showLatestNovels } with _options to avoid the eslint warning
  3. Version inflation (plugins/arabic/rewayahfans.ts:18) — Changed version from 5.0.0 to 1.0.0
  4. Missing metadata in parseNovel (plugins/arabic/rewayahfans.ts:76) — Added extraction for cover, summary, author, genres, and status so the novel detail page no longer shows src="undefined"

Additional fix: genres field type was string (comma-separated) in SourceNovel but the code assigned string[] — fixed with genres.join(', ').

Cleanup: removed development markers and Arabic section notes, replaced with concise English comments.

@hamedhani1998

hamedhani1998 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

@K1ngfish3r

@K1ngfish3r

K1ngfish3r commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

@K1ngfish3r

image author and status return https, whilst summary returns 5 stars `%d8%ad%d9%8a%d8%b1%d8%a9-%d8%a7%d9%84%d8%a3%d9%85%d9%8a%d8%b1%d8%a9-%d8%a7%d9%84%d8%ab%d8%a7%d9%86%d9%8a%d8%a9-%d8%a7%d9%84%d8%aa%d9%8a-%d8%aa%d9%85-%d8%a7%d9%84%d8%aa%d8%b6%d8%ad%d9%8a%d8%a9-%d8%a8`

covers work now, progress

my recommendation to you, would be to curl all the novel htmls in the site to a folder (this is possible because this site has 1 page of novels), and then iterate over it so you can catch all the outliers
once all the usecases have been caught, update the plugin and push here

hamedhani1998 pushed a commit to hamedhani1998/lnreader-plugins that referenced this pull request Aug 2, 2026
@hamedhani1998

hamedhani1998 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@K1ngfish3r

image author and status return https, whilst summary returns 5 stars %d8%ad%d9%8a%d8%b1%d8%a9-%d8%a7%d9%84%d8%a3%d9%85%d9%8a%d8%b1%d8%a9-%d8%a7%d9%84%d8%ab%d8%a7%d9%86%d9%8a%d8%a9-%d8%a7%d9%84%d8%aa%d9%8a-%d8%aa%d9%85-%d8%a7%d9%84%d8%aa%d8%b6%d8%ad%d9%8a%d8%a9-%d8%a8
covers work now, progress

my recommendation to you, would be to curl all the novel htmls in the site to a folder (this is possible because this site has 1 page of novels), and then iterate over it so you can catch all the outliers once all the usecases have been caught, update the plugin and push here

WhatsApp Image 2026-08-03 at 12 54 47 PM "Why are the tests no longer working? All sources are failing/down, displaying this error. Please fix the issue." @K1ngfish3r

@K1ngfish3r

Copy link
Copy Markdown
Collaborator

@K1ngfish3r

image author and status return https, whilst summary returns 5 stars %d8%ad%d9%8a%d8%b1%d8%a9-%d8%a7%d9%84%d8%a3%d9%85%d9%8a%d8%b1%d8%a9-%d8%a7%d9%84%d8%ab%d8%a7%d9%86%d9%8a%d8%a9-%d8%a7%d9%84%d8%aa%d9%8a-%d8%aa%d9%85-%d8%a7%d9%84%d8%aa%d8%b6%d8%ad%d9%8a%d8%a9-%d8%a8
covers work now, progress
my recommendation to you, would be to curl all the novel htmls in the site to a folder (this is possible because this site has 1 page of novels), and then iterate over it so you can catch all the outliers once all the usecases have been caught, update the plugin and push here

WhatsApp Image 2026-08-03 at 12 54 47 PM "Why are the tests no longer working? All sources are failing/down, displaying this error. Please fix the issue." @K1ngfish3r

Can you check if there is an error on the console
I've also noticed this happening if you have more than one vite server open at the same time, so you may try to close all browsers and vite servers then retry (or restart pc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants