ci: fmt/clippy/test gate + tree cleanup#11
Merged
Merged
Conversation
Add `ci` + `fmt-fix` Makefile targets (fmt-check + clippy -D warnings + unit tests -- per crate, for stage0's non-workspace UEFI+host mix) and a `ci` job to the workflow, with `build` renamed to the clean contexts build-x86_64 / build-aarch64 (needs: ci). This is the uniform CI gate the workspace branch ruleset requires. The tree had never been fmt/clippy-checked in CI; bring it clean, no #[allow]: - rustfmt across all crates - is_multiple_of (clippy --fix) - drop 2 redundant core::mem::forget in the ENA driver (the Dma buffers have no Drop, so they already leak for the device lifetime -- behavior identical) - de-prefix the PciMapOp (BusMaster*) and Domain (Stage1*) enum variants - extract the repeated admission tuple to a `type Admitted` alias make ci green (fmt + clippy + stage0-sign golden test). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the uniform CI gate (fmt + clippy + unit tests) that the workspace branch ruleset requires, and cleans the tree so it passes.
ci+fmt-fixMakefile targets — fmt-check +clippy -D warnings+ unit tests. stage0 isn't a cargo workspace (4 independent crates, UEFI + host), so it lints the UEFI crates on the uefi target and runsstage0-sign's tests on host.cijob;buildnowneeds: ciand renamed to the clean contextsbuild-x86_64/build-aarch64.#[allow]) — never fmt/clippy-checked in CI before: rustfmt all crates;is_multiple_of; dropped 2 redundantcore::mem::forgetin the ENA driver (theDmabuffers have noDrop, so they already leak for the device lifetime — identical behavior); de-prefixed thePciMapOp(BusMaster*) andDomain(Stage1*) enum variants; extracted the repeated admission tuple to atype Admitted.make cigreen locally (fmt + clippy +stage0-signgolden test).🤖 Generated with Claude Code