Skip to content

http: hand back response body without copying it #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarryR merged 1 commit into from
Jul 5, 2026
Merged

http: hand back response body without copying it #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/stage0/src/http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ pub fn fetch(
req.push_str("Connection: close\r\nUser-Agent: stage0\r\n\r\n");
crate::sdbg!("stage0: HTTP {} {url}", method.as_str());

let raw = tcp4::exchange(ip, port, req.as_bytes())?;
let mut raw = tcp4::exchange(ip, port, req.as_bytes())?;

let sep = find_subslice(&raw, b"\r\n\r\n").ok_or_else(|| {
crate::slog!("stage0: response had no header terminator");
Expand All @@ -88,7 +88,9 @@ pub fn fetch(
crate::slog!("stage0: could not parse HTTP status line");
Status::PROTOCOL_ERROR
})?;
let body = raw[sep + 4..].to_vec();
// Hand back the body by reusing `raw`'s allocation (drop the headers in place)
// instead of copying the whole payload into a fresh Vec.
let body = raw.split_off(sep + 4);
crate::sdbg!("stage0: response {status}, {} body bytes", body.len());
Ok((status, body))
}
Expand Down