ci: fmt/clippy/test gate + tree cleanup#20
Merged
Merged
Conversation
Add workspace-wide `ci` + `fmt-fix` Makefile targets (fmt-check + clippy -D warnings + test) and a `ci` job to the workflow, with `build` renamed to the clean contexts build-x86_64 / build-aarch64 (needs: ci). The uniform CI gate the workspace branch ruleset requires. Bring the tree clean, no #[allow]: - rustfmt across the workspace - deploy: bundle the shared (dir, arch, bases) triple into an ArchCtx to fix too_many_arguments on build_payload / wrap_manifest - stage1: fix unit_arg (split Ok(println!(..))), unnecessary u32 casts, and a needless question-mark (clippy --fix) make ci green (fmt + clippy + 27 tests). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the uniform CI gate (fmt + clippy + tests) that the workspace branch ruleset requires, and cleans the workspace so it passes.
ci+fmt-fixMakefile targets — workspace-widecargo fmt --check+clippy --workspace -D warnings+test --workspace.cijob;buildnowneeds: ciand renamed tobuild-x86_64/build-aarch64.#[allow]) — never fmt/clippy-checked before: rustfmt across the workspace;deploybundles the shared(dir, arch, bases)triple into anArchCtx(fixestoo_many_argumentsonbuild_payload/wrap_manifest);stage1fixesunit_arg(splitOk(println!(..))), unnecessaryu32casts, and a needless question-mark.make cigreen locally (fmt + clippy + 27 tests).🤖 Generated with Claude Code