header_parse to handle comment edge cases - #62
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the experimental implementation header parser so it can correctly detect public method declarations that include trailing // comments and declarations spanning multiple lines, and extends the existing complex fixture/test to cover those edge cases.
Changes:
- Extend
parseImplHeaderto strip trailing//comments and accumulate multi-line declarations until;is reached. - Add new method declarations (trailing-comment + multi-line) to the complex fixture header.
- Add test assertions to ensure the newly introduced methods are parsed as public methods.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cpp-generator/experimental/impl_header_parser.cpp |
Accumulates multi-line declarations and strips trailing // comments before parsing method declarations. |
tests/experimental/fixtures/complex_impl.h |
Adds public method declarations exercising trailing-comment and multi-line declaration parsing. |
tests/experimental/test_impl_header_parser.cpp |
Adds assertions verifying the parser includes the new methods from the complex fixture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
hey there @delphamk ! Thanks for your contribution! Many of the cases you mention seem to be fixed in latest master already, could you please rebase? |
No description provided.