fix(doctests): raise launch_timeout for the nix run . UI tests - #77
Merged
Conversation
The tutorial doc-test went red on ubuntu with inspector not available on port 3768 after 120s with `building '...-logos-standalone-app-1.0.0.drv'` as the last line of the launch log: the app was still compiling when the clock ran out. The runner pre-builds `nix run .` as `nix build .`, which is packages.default — the UI plugin. But `nix run .` launches apps.default, the standalone app, whose closure (logos-standalone-app plus the bundled backend modules) is not covered by that warm build, so it compiles during launch and is charged against the default 120s inspector wait. Give the three `nix run` UI tests the same launch_timeout the logos-wallet-module spec already uses for exactly this reason. Nothing here is rendered into the generated Markdown. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📊 Tutorial execution reportRendered tutorial alongside the commands actually run and their output (updated each run, commit Pages can take a minute to update after the run finishes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The tutorial doc-test went red on ubuntu in the nightly with:
and the last line of the launch log was
building '/nix/store/…-logos-standalone-app-1.0.0.drv'…— the app was still compiling when the inspector clock expired. Nothing was actually broken.The runner turns a
nix run .launch into anix build .warm-up, but that ispackages.default— the UI plugin.nix run .launchesapps.default, the standalone app, whose closure (logos-standalone-app+ the bundled backend modules) is not in the plugin's build closure. So it compiles during launch, charged against the default 120slaunch_timeout.What
Add
launch_timeout: 900to the threenix runUI tests, with a comment explaining the gap. This is the same knob (and the same reason) thelogos-wallet-modulespec already documents.launch_timeoutis harness configuration — it is not rendered into the generated Markdown, so the tutorials themselves are unchanged.Note
The
nix build .-vs-apps.defaultgap is really a harness-level shortcoming; raising the per-spec timeout is the same mitigation every other affected spec uses. A follow-up inlogos-doctestcould make the warm-up coverapps.defaultand remove the need for this.🤖 Generated with Claude Code